Skip to content

Upgrade TinyMCE to latest and fix broken script path and image upload#347

Open
apodacaduron wants to merge 3 commits into
mainfrom
update-tinymce
Open

Upgrade TinyMCE to latest and fix broken script path and image upload#347
apodacaduron wants to merge 3 commits into
mainfrom
update-tinymce

Conversation

@apodacaduron
Copy link
Copy Markdown
Contributor

@apodacaduron apodacaduron commented Jun 8, 2026

Description

Updates TinyMCE to the latest version and fix file upload and import path:

  • Changed the location of tinymce.min.js from js/tinymce/js/tinymce/ to js/tinymce/, breaking the editor on all pages. Updated the <script> src in actors, bulletins, incidents, and locations templates.
  • The /api/inline/upload endpoint was returning {"data": {"location": "..."}} (standard app response shape), but TinyMCE expects a flat {"location": "..."}. Changed the endpoint to return the flat response directly via jsonify.

How to Test

  1. Open any Bulletin, Actor, Incident, or Location — confirm the rich text editor loads correctly.
  2. In the rich text editor, click the image button and upload an image file — confirm it inserts into the editor without an "Invalid JSON" error.

IMPORTANT NOTE

The CI retire.js scan will report false positives for CVE-2026-47759, CVE-2026-47762, and CVE-2026-47761 on TinyMCE 8.6.0, which contains the fixes for these CVEs. A correction to the retire.js vulnerability database is pending in RetireJS/retire.js#580.

@apodacaduron apodacaduron self-assigned this Jun 8, 2026
@apodacaduron apodacaduron requested a review from level09 as a code owner June 8, 2026 15:18
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 8, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 95892a9a-797b-4bf1-a43c-342db7756e56

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-tinymce

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@apodacaduron apodacaduron changed the title Update tinymce Upgrade to latest and fix broken script path and image upload Jun 8, 2026
@apodacaduron apodacaduron changed the title Upgrade to latest and fix broken script path and image upload Upgrade TinyMCE to latest and fix broken script path and image upload Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant