Skip to content

fix(export): stop leaking internal description in public archive export#346

Open
level09 wants to merge 1 commit into
mainfrom
fix/public-export-strip-internal-description
Open

fix(export): stop leaking internal description in public archive export#346
level09 wants to merge 1 commit into
mainfrom
fix/public-export-strip-internal-description

Conversation

@level09

@level09 level09 commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Problem

The public archive export (`flask export public`, added in #345) serialized both the internal `description` and the SJAC-authored `public_description` into `documents.json`. The internal `description` holds staff notes that are not meant for public consumption, so it should never leave Bayanat.

Fix

Drop `description` from `serialize_bulletin()`. Only `public_description` is exported now.

Notes

  • The archive import side reads the field with `doc.get("description")`, so a missing key does not break import (it just stores NULL).
  • Follow-ups for a separate pass: the archive's `EXPORT_SCHEMA.md` still lists `description` as required and the archive schema/FTS still index it. Those should be reconciled, and redaction of `public_description` itself is tracked separately.

The public archive export emitted both the internal description and the
SJAC-authored public_description. Internal notes are not meant for public
consumption, so export only public_description.
@level09 level09 requested a review from apodacaduron as a code owner June 7, 2026 15:42
@level09 level09 self-assigned this Jun 7, 2026
@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 80c09645-f0c3-46eb-9911-d1182fb3ff7f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/public-export-strip-internal-description

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants