fix(export): stop leaking internal description in public archive export#346
Open
level09 wants to merge 1 commit into
Open
fix(export): stop leaking internal description in public archive export#346level09 wants to merge 1 commit into
level09 wants to merge 1 commit into
Conversation
The public archive export emitted both the internal description and the SJAC-authored public_description. Internal notes are not meant for public consumption, so export only public_description.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
apodacaduron
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The public archive export (`flask export public`, added in #345) serialized both the internal `description` and the SJAC-authored `public_description` into `documents.json`. The internal `description` holds staff notes that are not meant for public consumption, so it should never leave Bayanat.
Fix
Drop `description` from `serialize_bulletin()`. Only `public_description` is exported now.
Notes