Added smooth and non-smooth prediction functions with tests and comments#61
Open
ClaudioZeni wants to merge 1 commit into
Open
Added smooth and non-smooth prediction functions with tests and comments#61ClaudioZeni wants to merge 1 commit into
ClaudioZeni wants to merge 1 commit into
Conversation
356962e to
138ecc9
Compare
Collaborator
|
I think this PR can be accepted and merged. Is there some more work to do maybe? |
Collaborator
|
One small problem is that "density_est" does not appear in the docstring. On the algorithm I think also @alexdepremia could give his opinion |
Collaborator
Author
|
On my side the PR can be merged, I guess it's up to the reviewers
…On Wed, Jul 6, 2022 at 10:38 AM Iuri Macocco ***@***.***> wrote:
I think this PR can be accepted and merged. Is there some more work to do
maybe?
—
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJWOAJB4R4FNNJ4TMVDAN3VSVHZPANCNFSM5WROLGXQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
|
Hi, sorry for the late reply. I think it can be merged, but we should clearly state that it is an experimental feature (it has not been published). |
a70caa7 to
685e691
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added two predict functions to Clustering class.
One follows the Density Peaks criteria and assigns cluster labels based on the label of the closest neighbour of higher density.
Such density can be computed using PAk or kstarNN. This function predicts only labels and assigns probabilities that are always 1 or 0.
The second function employs a smoothed majority rule to assign labels and label probabilities.
Points in the kstar neighbourhood are weighted according to a normalized inverse square distance from the out-of-set point.
Label is then predicted according to weighted majority rule, and probabilities are given by the weighted population of each label.
Types of changes
[New Feature] Allows using Clustering to predict the labels and probability of each label for out-of-set points.
Checklist