Skip to content

Fix git-review detection with SSH host aliases#424

Open
cyphercodes wants to merge 1 commit into
sirmalloc:mainfrom
cyphercodes:fix/git-review-ssh-host-alias
Open

Fix git-review detection with SSH host aliases#424
cyphercodes wants to merge 1 commit into
sirmalloc:mainfrom
cyphercodes:fix/git-review-ssh-host-alias

Conversation

@cyphercodes

Copy link
Copy Markdown

Summary

  • resolve SSH host aliases with ssh -G before git-review provider selection
  • use the resolved host when constructing fallback --repo refs
  • add coverage for an origin like git@mygit:owner/repo.git resolving to GitHub

Fixes #419.

Tests

  • bun test src/utils/__tests__/git-review-cache.test.ts
  • bun run lint
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

git-review shows (no PR) when origin uses an SSH host alias (e.g. git@myalias:owner/repo)

1 participant