fix: correct WebKit.framework capitalization in iOS post-build#43
Open
biboete wants to merge 1 commit into
Open
fix: correct WebKit.framework capitalization in iOS post-build#43biboete wants to merge 1 commit into
biboete wants to merge 1 commit into
Conversation
The iOS post-build added "Webkit.framework", but Apple's framework is "WebKit.framework" (capital K). Framework names are case-sensitive, so the wrong casing can cause linker/build issues. Fixes singular-labs#42.
nursingular
approved these changes
Jun 11, 2026
Collaborator
|
hi @biboete thanks for making this PR - we'll include it in our next official release 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42.
SingularPostBuild.csadded the iOS framework as"Webkit.framework", but Apple's framework isWebKit.framework(capitalK). Framework names are case-sensitive, so the incorrect casing can lead to linker/build problems on case-sensitive setups.Single-character change on the
AddFrameworkToProjectline; the surrounding frameworks (AdSupport.framework,StoreKit.framework, etc.) are already correctly cased.