[r] Expand batched reader support to AnnotationMatrix arrays#548
Merged
aaronwolen merged 6 commits intomain-oldfrom Nov 17, 2022
Merged
Conversation
|
This pull request has been linked to Shortcut Story #23433: Add batch reader to all TileDBArray-based classes. |
johnkerl
approved these changes
Nov 17, 2022
|
|
||
| # TODO: currently tiledb-r's batched reader ignores return_as and a | ||
| # data.frame is always returned. When this is addressed we'll need to | ||
| # add class-specific concatenation logic here. |
Contributor
There was a problem hiding this comment.
Do we have a tracking Shortcut story open?
Member
Author
There was a problem hiding this comment.
We do indeed: [sc-23436]
aaronwolen
deleted the
aaronwolen/sc-23433/add-batch-reader-to-all-tiledbarray-based
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands batched reader support to the
AnnotationMatrixclass. It's off by default but can be enabled with thebatch_modeargument that was added to theto_matrix()method.