Skip to content

[python] Apply black/isort/flake8/mypy to all repo .py files#453

Closed
johnkerl wants to merge 3 commits intomainfrom
kerl/qa-all-py
Closed

[python] Apply black/isort/flake8/mypy to all repo .py files#453
johnkerl wants to merge 3 commits intomainfrom
kerl/qa-all-py

Conversation

@johnkerl
Copy link
Copy Markdown
Contributor

@johnkerl johnkerl commented Oct 21, 2022

Previously, only within apis/python, and even then, not for apis/python/tests.

Some of our challenges with #400, #446, and #447 have had to do with typeguard, at unit-test time, reaching into .py files it had not visited before. Here we try to avoid future such surprises.

@johnkerl johnkerl force-pushed the kerl/qa-all-py branch 2 times, most recently from b12d211 to c2c439e Compare October 21, 2022 21:39
@johnkerl johnkerl marked this pull request as draft October 21, 2022 21:51
@johnkerl johnkerl changed the title Apply black/isort/flake8/mypy to all repo .py files [python] Apply black/isort/flake8/mypy to all repo .py files Oct 26, 2022
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 66.87% // Head: 56.74% // Decreases project coverage by -10.12% ⚠️

Coverage data is based on head (b04f8d6) compared to base (e636da5).
Patch has no changes to coverable lines.

❗ Current head b04f8d6 differs from pull request most recent head 12fefb8. Consider uploading reports for the commit 12fefb8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #453       +/-   ##
===========================================
- Coverage   66.87%   56.74%   -10.13%     
===========================================
  Files          64       38       -26     
  Lines        3384     1542     -1842     
===========================================
- Hits         2263      875     -1388     
+ Misses       1121      667      -454     
Flag Coverage Δ
python ?
r 56.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/python/src/tiledbsoma/dense_nd_array.py
...is/python/src/tiledbsoma/test_general_utilities.py
apis/python/src/tiledbsoma/general_utilities.py
apis/python/src/tiledbsoma/measurement.py
apis/python/src/tiledbsoma/collection.py
apis/python/src/tiledbsoma/constants.py
apis/python/src/tiledbsoma/util_arrow.py
apis/python/src/tiledbsoma/logging.py
apis/python/src/tiledbsoma/metadata_mapping.py
apis/python/src/tiledbsoma/tiledb_array.py
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johnkerl
Copy link
Copy Markdown
Contributor Author

Closed in favor of #711

@johnkerl johnkerl closed this Jan 13, 2023
@johnkerl johnkerl deleted the kerl/qa-all-py branch January 20, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants