Skip to content

crypto: validate BBS proof parameters #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ap4sh wants to merge 1 commit into
base: stable
Choose a base branch
from
+24 −0
Open

crypto: validate BBS proof parameters #1810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Simplex/Messaging/Crypto/BBS.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,10 @@ bbsProofVerify ::
[ByteString] ->
IO Bool
bbsProofVerify (BBSPublicKey pk) (BBSProof proof) (BBSHeader header) (BBSPresHeader ph) disclosedIdxs numMessages disclosedMsgs
| numMessages < 0 = pure False
| length disclosedIdxs /= length disclosedMsgs = pure False
| not (ascendingInRange disclosedIdxs numMessages) = pure False
| B.length proof /= bbsProofLen (numMessages - length disclosedIdxs) = pure False
| otherwise =
withBS pk $ \pkPtr _ ->
withBS proof $ \proofPtr proofLen ->
Expand Down
22 changes: 22 additions & 0 deletions tests/CoreTests/CryptoTests.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ cryptoTests = do
it "should reject tampered proof" testBBSTamperedProof
it "should reject wrong disclosed message" testBBSWrongMessage
it "should reject wrong public key" testBBSWrongKey
it "should reject invalid proof parameters" testBBSInvalidProofParams
it "should produce unlinkable proofs" testBBSUnlinkable
it "should produce proof of expected size" testBBSProofSize
it "should roundtrip JSON and reject wrong-length input" testBBSJSON
Expand Down Expand Up @@ -355,6 +356,27 @@ testBBSWrongKey = do
result <- bbsProofVerify pk2 proof bbsHeader ph bbsDisclosedIdxs 3 bbsDisclosedMsgs
result `shouldBe` False

testBBSInvalidProofParams :: IO ()
testBBSInvalidProofParams = do
Right (pk, sk) <- bbsKeyGen
Right sig <- bbsSign sk bbsHeader bbsMessages
let ph = BBSPresHeader "test-nonce-invalid"
Right proof <- bbsProofGen pk sig bbsHeader ph bbsDisclosedIdxs bbsMessages
bbsProofGen pk sig bbsHeader ph [2, 1] bbsMessages
`shouldReturn` Left "bbsProofGen: invalid disclosed indexes"
bbsProofGen pk sig bbsHeader ph [1, 1] bbsMessages
`shouldReturn` Left "bbsProofGen: invalid disclosed indexes"
bbsProofGen pk sig bbsHeader ph [3] bbsMessages
`shouldReturn` Left "bbsProofGen: invalid disclosed indexes"
bbsProofVerify pk proof bbsHeader ph bbsDisclosedIdxs 3 ["2026-07-31"]
>>= (`shouldBe` False)
bbsProofVerify pk proof bbsHeader ph [2, 1] 3 bbsDisclosedMsgs
>>= (`shouldBe` False)
bbsProofVerify pk proof bbsHeader ph bbsDisclosedIdxs 4 bbsDisclosedMsgs
>>= (`shouldBe` False)
bbsProofVerify pk proof bbsHeader ph [] (-1) []
>>= (`shouldBe` False)

testBBSUnlinkable :: IO ()
testBBSUnlinkable = do
Right (pk, sk) <- bbsKeyGen
Expand Down