lib: parse bracketed IPv6 server addresses#1807
Open
shumvgolove wants to merge 2 commits into
Open
Conversation
shumvgolove
force-pushed
the
sh/ipv6-parse-ench
branch
from
2a01f52 to
15d86f9
Compare
epoberezkin
reviewed
Jun 20, 2026
| instance StrEncoding SrvLoc where | ||
| strEncode (SrvLoc host port) = B.pack $ host <> if null port then "" else ':' : port | ||
| strP = SrvLoc <$> host <*> (port <|> pure "") | ||
| strEncode (SrvLoc host port) = strEncode host <> B.pack (if null port then "" else ':' : port) |
Member
There was a problem hiding this comment.
Suggested change
| strEncode (SrvLoc host port) = strEncode host <> B.pack (if null port then "" else ':' : port) | |
| strEncode (SrvLoc host port) = case host of | |
| THIPv6 _ | not (null port) -> strEncode ('[', host, ']') <> B.pack (':' : port) | |
| _ -> strEncode host |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/trailofbits/ptp-simplexmq/issues/9