Merged
Conversation
Updated from PHP 8.3 to PHP 8.4 Removed mysql from repo due to key failure Added default-mysql-client from apt Added /var/log/simplerisk directory Installed rsyslog Added supervisord configuration Installed logrotate Installed curl
|
|
||
| # Using simplerisk user from here | ||
| USER simplerisk | ||
| #USER simplerisk |
Contributor
There was a problem hiding this comment.
Why are we commenting this? The reason to use a separate user than root is for security purposes
Contributor
There was a problem hiding this comment.
Here is an example of a Dockerfile that has a separate user but also runs supervisord https://sourcegraph.com/github.com/CJackHwang/AIstudioProxyAPI/-/blob/docker/Dockerfile?L99-101
Co-authored-by: P. <WolfangAukang@users.noreply.github.com>
Contributor
|
Another issue with this PR is that it is now installing MariaDB client instead of MySQL client: As it uses |
WolfangAukang
force-pushed
the
simplerisk-minimal-updates
branch
3 times, most recently
from
2895f5f to
1327119
Compare
WolfangAukang
force-pushed
the
simplerisk-minimal-updates
branch
from
1327119 to
ec4157c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated from PHP 8.3 to PHP 8.4
Removed mysql from repo due to key failure
Added default-mysql-client from apt
Added /var/log/simplerisk directory
Installed rsyslog
Added supervisord configuration
Installed logrotate
Installed curl