Skip to content

AB- programs do file#448

Closed
ANBurdett wants to merge 3 commits intomainfrom
AB-programs_do_file
Closed

AB- programs do file#448
ANBurdett wants to merge 3 commits intomainfrom
AB-programs_do_file

Conversation

@ANBurdett
Copy link
Copy Markdown
Contributor

In this branch, I have included the draft program do files, in which all of the Excel files containing the process estimates (except wages) are produced using the programs file.

A few things worth noting:

  • The Excel file name is now dynamic and fed into the relevantprogram.
  • There are a few different possible processing programs. The one to use depends on the type of model you are running.
  • Probit and logit models are processed in the same way, even if the probit option is always used.

Review Request:
@andrewbaxter439 - It would be great if you could take a look at the files for the well-being, mental health and financial distress to see if they are working as expected.
Please let me know if you spot any bugs or have any issues.

The one obvious thing that is outstanding to me is that some of the labels are incorrect. Specifically, it is easier to create dummy variables from categorical variables with the name that will be picked up by SimPaths. Lags are dealt with in the code, but category names are not. I think the best place for these variables to be created is in the variable_update do-file. @dariaple is currently updating this file (along with the full set of estiamtion do files) with the new variable names, so perhaps this is best added after she has completed that work. However this shouldn't impact the programs themselves it just alters what is fed into them.

ANBurdett and others added 2 commits March 24, 2026 23:41
@ANBurdett ANBurdett self-assigned this Mar 31, 2026
@ANBurdett ANBurdett requested review from igelstorm March 31, 2026 13:05
@andrewbaxter439
Copy link
Copy Markdown
Collaborator

Hi @ANBurdett - thanks for doing this! keen to give the new programs do file a go and really appreciate that it's been worked on. Although in this PR it seems to only be touching files in the validation folder, from the above description I would presume the 'input/InitialPopulations/compile/RegressionEstimates' do files are the ones intended to be changed?

Let me know if I've misunderstood and should continue with review of these ones. Will be next week before I get round to it though. Apologies!

@ANBurdett ANBurdett closed this Apr 1, 2026
@ANBurdett ANBurdett deleted the AB-programs_do_file branch April 1, 2026 17:35
@ANBurdett
Copy link
Copy Markdown
Contributor Author

Hi Andy,

Not at all, my fault! Still working out this GitHub thing by the looks of it.

I just created another branch with the updated estimation do-files, and issued a pull request to you and Eric. Please let me know if there are still issues. Keen to understand what I am doing wrong.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants