Conversation
Deleted old validation plot files and uploaded new validation do files.
|
Hi @ANBurdett - thanks for doing this! keen to give the new programs do file a go and really appreciate that it's been worked on. Although in this PR it seems to only be touching files in the validation folder, from the above description I would presume the 'input/InitialPopulations/compile/RegressionEstimates' do files are the ones intended to be changed? Let me know if I've misunderstood and should continue with review of these ones. Will be next week before I get round to it though. Apologies! |
|
Hi Andy, Not at all, my fault! Still working out this GitHub thing by the looks of it. I just created another branch with the updated estimation do-files, and issued a pull request to you and Eric. Please let me know if there are still issues. Keen to understand what I am doing wrong. Thanks! |
In this branch, I have included the draft program do files, in which all of the Excel files containing the process estimates (except wages) are produced using the
programsfile.A few things worth noting:
Review Request:
@andrewbaxter439 - It would be great if you could take a look at the files for the well-being, mental health and financial distress to see if they are working as expected.
Please let me know if you spot any bugs or have any issues.
The one obvious thing that is outstanding to me is that some of the labels are incorrect. Specifically, it is easier to create dummy variables from categorical variables with the name that will be picked up by SimPaths. Lags are dealt with in the code, but category names are not. I think the best place for these variables to be created is in the
variable_updatedo-file. @dariaple is currently updating this file (along with the full set of estiamtion do files) with the new variable names, so perhaps this is best added after she has completed that work. However this shouldn't impact the programs themselves it just alters what is fed into them.