Skip to content

put country setters in right places #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewbaxter439 merged 1 commit into from
Aug 8, 2025
Merged

put country setters in right places #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/simpaths/experiment/SimPathsMultiRun.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,16 @@ public static void main(String[] args) {
} else {
countryString = "United Kingdom";
}
country = Country.getCountryFromNameString(countryString);
String valueYear = lastDatabaseCountryAndYear.getValue(country.toString()).toString();
startYear = Integer.parseInt(valueYear);
} catch (NullPointerException e) {
System.out.println("No last database country and year found.");
countryString = "United Kingdom";
country = Country.getCountryFromNameString(countryString);
Comment on lines +88 to +94
Copy link

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The country variable is used here but may still be null if an exception occurs during the Country.getCountryFromNameString() call on line 88, which would cause a NullPointerException.

Suggested change
country = Country.getCountryFromNameString(countryString);
String valueYear = lastDatabaseCountryAndYear.getValue(country.toString()).toString();
startYear = Integer.parseInt(valueYear);
} catch (NullPointerException e) {
System.out.println("No last database country and year found.");
countryString = "United Kingdom";
country = Country.getCountryFromNameString(countryString);
country = Country.getCountryFromNameString(countryString);
if (country == null) {
country = Country.UNITED_KINGDOM;
}
String valueYear = lastDatabaseCountryAndYear.getValue(country.toString()).toString();
startYear = Integer.parseInt(valueYear);
} catch (NullPointerException e) {
System.out.println("No last database country and year found.");
countryString = "United Kingdom";
country = Country.getCountryFromNameString(countryString);
if (country == null) {
country = Country.UNITED_KINGDOM;
}

Copilot uses AI. Check for mistakes.
startYear = 2019;
}

country = Country.getCountryFromNameString(countryString);

if (innovationArgs!=null)
updateLocalParameters(innovationArgs);
Expand Down