Conversation
…effects_mental_health Adding UC effects on mental health - clean branch
Add financial distress
Adding missing getters and setters for the PersistHealthStatistics method
Summary of updates: •Estimation sample and initial populations now cover the years 2011–2023. •Added year-specific dummies (y2020, y2021) to all processes to capture the impact of the pandemic. •Ethnicity variables: -Included the four-category variable dot in all processes. -Added an extended ethnicity variable dot01 to initial populations with six categories. •Replaced dhe with its physical (dhe_pcs) and mental (dhe_mcs) health components wherever health was included. •Replaced disability dummy dlltsd with dlltsd01, which captures both self-reported disability and receipt of disability benefits. •Weights: All processes now use dimxwt (Individual Cross-Sectional Weight). •Automatised the production of Excel files with estimates. •There are process-specific updates detailed in the Excel files with estimates. •Added an Excel file summarising the structure of covariates used in the estimates.
A new option to persist health statistics added to the collector was annotated with @GUIParameter, which creates a menu field in the SimPath's GUI. However JAS-mine-GUI requires getters and setters for the above to work, as the field is private. This PR adds the required getter and setter methods fixing the issue.
pbronka
suggested changes
Jul 4, 2025
Contributor
pbronka
left a comment
pbronka
left a comment
There was a problem hiding this comment.
Hi @dariaple, thank you for this. I think this PR might be different to what was intended - I think what happened is that:
- The changes described in the PR were made directly to the develop branch (so there is no PR to merge - they are all already a part of the develop branch).
- This PR would result in all recent changes from the develop branch being merged into the stable main branch (295 commits). I don't think this was the goal so I'd recommended closing this PR without merging.
(1) unfortunately means that if there is any problem with these changes (the tests currently seems to be failing), the model in the develop branch will break. I will look into it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of updates:
•Estimation sample and initial populations now cover the years 2011–2023.
•Added year-specific dummies (y2020, y2021) to all processes to capture the impact of the pandemic.
•Ethnicity variables:
-Included the four-category variable dot in all processes.
-Added an extended ethnicity variable dot01 to initial populations with six categories.
•Replaced dhe with its physical (dhe_pcs) and mental (dhe_mcs) health components wherever health was included.
•Replaced disability dummy dlltsd with dlltsd01, which captures both self-reported disability and receipt of disability benefits.
•Weights: All processes now use dimxwt (Individual Cross-Sectional Weight).
•Automatised the production of Excel files with estimates.
•There are process-specific updates detailed in the Excel files with estimates.
•Added an Excel file summarising the structure of covariates used in the estimates.