Skip to content

multirun -DBsetup option now checks whether training data is used#186

Merged
andrewbaxter439 merged 2 commits intodevelopfrom
bugfix/185-multirun-db-setup-currently-doesnt-check-whether-training-data-should-be-used
Jun 2, 2025
Merged

multirun -DBsetup option now checks whether training data is used#186
andrewbaxter439 merged 2 commits intodevelopfrom
bugfix/185-multirun-db-setup-currently-doesnt-check-whether-training-data-should-be-used

Conversation

@andrewbaxter439
Copy link
Copy Markdown
Collaborator

What

  • adds a test to the setup of multirun database setup to check if training data should be used
  • mimics what singlerun.jar -Setup aims to do

Why

  • ideally, all setup and run can be done/tested consistently in the SimPathsMultiRun class
  • This adds testability

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to the multirun database setup by checking whether training data is available before proceeding, mimicking the behavior of singlerun.jar -Setup.

  • Introduces a FileUtils-based check for CSV files to conditionally set the training flag.
  • Enhances testability in the SimPathsMultiRun class by integrating this data availability check.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@andrewbaxter439 andrewbaxter439 added the bug Something isn't working label May 30, 2025
Copy link
Copy Markdown
Contributor

@justin-ven justin-ven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing here sets warning bells off for me.

@andrewbaxter439
Copy link
Copy Markdown
Collaborator Author

thanks @justin-ven! will merge now

@andrewbaxter439 andrewbaxter439 merged commit d0355cf into develop Jun 2, 2025
4 checks passed
@andrewbaxter439 andrewbaxter439 deleted the bugfix/185-multirun-db-setup-currently-doesnt-check-whether-training-data-should-be-used branch June 5, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants