Introduce lag of hours worked variable#172
Merged
andrewbaxter439 merged 13 commits intosimpaths:developfrom Jun 2, 2025
Merged
Introduce lag of hours worked variable#172andrewbaxter439 merged 13 commits intosimpaths:developfrom
andrewbaxter439 merged 13 commits intosimpaths:developfrom
Conversation
Replace incorrect comment end character to prevent commenting out entire master file
Contributor
Author
|
Stuck with this until #173 is resolved |
Contributor
Author
|
This should now work, except for the integrations tests which need to be updated if we are happy. |
Collaborator
|
will check this out and see about updating statistics 👍 |
andrewbaxter439
approved these changes
May 30, 2025
Collaborator
andrewbaxter439
left a comment
andrewbaxter439
left a comment
There was a problem hiding this comment.
Looks good, with new Statistics files in should be ready to merge
| * Working directory | ||
| global dir_work "C:\MyFiles\99 DEV ENV\JAS-MINE\data work\initial_populations" | ||
| *global dir_work "C:\MyFiles\99 DEV ENV\JAS-MINE\data work\initial_populations" | ||
| global dir_work "C:\Users\Patryk\Documents\SP_prep_pop" |
Collaborator
There was a problem hiding this comment.
tiny side comment - at some point would it be helpful to make these more generic somehow? Either leaving as active directory where Stata is launched or prompting user to enter directory relative to do files where the process can find the data? I've tried to run it mostly as relative from a working directory when I start Stata to keep my own file paths out of the files (and they wouldn't work for anyone else!)
| } | ||
|
|
||
| private List<Household> loadStaringPopulation() { | ||
| private List<Household> loadStartingPopulation() { |
…ation Add new Statistics to fix initial pop bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As required by the updated labour supply estimates (see discussion: #163), this PR introduces the lag(1) of the hours worked variable (lhw).
This PR includes:
Uncommenting previously commented-out code in the do-files, enabling them to run as intended.
Introducing a new variable, l1_lhw, which is a lagged version of lhw, along with some very simple imputation rules. I am happy to accept further commits to refine this or to introduce a more robust imputation procedure.
TODO:
Modify the data parser in the simulation to accommodate this new variable.
Consider whether l1_lhw should be replaced with the current value of lhw if a null value is returned.
Verify whether this change affects the labour supply predictions produced by the model.