Create an end-to-end test#162
Conversation
0dbf7a1 to
58c6df4
Compare
andrewbaxter439
left a comment
There was a problem hiding this comment.
This all looks pretty awesome and very neat! Nice to be able to have end-to-end all handled within maven/JUnit.
Have suggested changes but actually not sure they're implementable. If parallelising three types of tests doesn't work then can just delete other tests.
|
One small, additional though - is it worth doing/possible to force the simpaths setup to use only the training data, for speed and consistency when running Think only way of overriding this would be to pass another command-line argument which is in turned passed to |
This is mainly to avoid confusion since IT is used to mean Italy in much of the codebase
This is a good point - it would definitely be good to make it easier to run locally even if you have other initial population data installed (without having to delete/move files). Ultimately I think the ideal is if it's always possible to configure which folder is used for input data; then this test could just make use of that feature. I'd be reluctant to add a less thought-out, potentially more awkward fix purely for use in the tests, though - so I suggest we deal with this separately. |
andrewbaxter439
left a comment
There was a problem hiding this comment.
This all looks pretty smashing! Hope this 'resolves' my prior review comments
What
run-simpathsGitHub Action into an integration test (which does the same thing)Statistics*.csvfiles)Why
Addresses #138. This will allow major changes to implementation details (e.g. optimisations, design changes) to be done much more safely, since these tests passing gives some assurance that the overall behaviour of the model hasn't changed.
How to use
mvn verify.mvn verify -D it.test=RunSimPathsIT#testVerifySimulationOutput