Feature/uc effects mental health#161
Feature/uc effects mental health#161andrewbaxter439 wants to merge 61 commits intosimpaths:developfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a simulation process for UC affecting mental health outcomes by extending models and tests to support UC-specific benefit flags.
- Enhances PersonTest with additional test scenarios for Health MCS stage 2.
- Extends the Person and BenefitUnit classes with new fields and methods to track UC and non-UC benefits.
- Updates Parameters to include UC-related variables and regression coefficient loading for health models.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/test/java/simpaths/model/PersonTest.java | Adds test scenarios and data classes for Health MCS stage 2 simulations. |
| src/main/java/simpaths/model/Person.java | Introduces new constructors and benefit flag variables/methods for UC. |
| src/main/java/simpaths/model/BenefitUnit.java | Implements new method (setReceivesBenefitsFlagUCNonUC) to set UC and non-UC flags. |
| src/main/java/simpaths/data/Parameters.java | Adds UC parameters and adjusts regression parameter loading for Health MCS2. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new process for simulating the impact of Universal Credit (UC) on the mental health of benefit recipients while updating various tax, benefit, and parameter handling mechanisms. Key changes include:
- Adding parameterized tests for MCS score evaluation in PersonTest.java.
- Modifying tax and benefit unit classes to aggregate and impute UC and legacy benefit flags.
- Updating configuration files and parameters to support toggling of UC rollout.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/simpaths/model/PersonTest.java | Adds tests for Health MCS stage 2 using parameterized scenarios. |
| src/main/java/simpaths/model/taxes/database/TaxDonorDataParser.java | Aggregates UC and legacy benefit flags from donor persons. |
| src/main/java/simpaths/model/taxes/DonorTaxUnitPolicy.java | Introduces new fields and accessors for UC and legacy benefits. |
| src/main/java/simpaths/model/taxes/DonorTaxImputation.java | Implements temporary weighted probability logic for UC imputation. |
| src/main/java/simpaths/model/DonorPersonPolicy.java | Adds columns and helper methods to calculate UC and legacy benefits. |
| src/main/java/simpaths/model/TaxEvaluation.java | Propagates new UC/legacy benefit flags via additional getters. |
| src/main/java/simpaths/model/Person.java | Adds new constructors, fields, and lag updates for UC flags. |
| src/main/java/simpaths/experiment/SimPathsMultiRun.java | Reorders YAML config processing to remove duplicate processing. |
| src/main/java/simpaths/experiment/SimPathsCollector.java | Adjusts statistics collection by correcting ordering and duplicate imports. |
| src/main/java/simpaths/data/Parameters.java | Updates parameter arrays and adds UC rollout flag along with new parameters. |
| config/uc_on.yml & config/no_uc.yml | Introduces configuration toggles to enable/disable UC rollout. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…health' into feature/uc-effects-mental-health
UpdateThis is becoming too big a pull request. Ideally will still be possible to have UC effects synced with main SimPaths branches rather than keep this one aside and still working. Actions
To examine
|
What
Why