-
Notifications
You must be signed in to change notification settings - Fork 1
Test docker #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AleJimenezRJ
wants to merge
16
commits into
main
Choose a base branch
from
test-docker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Test docker #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…script (incomplete)
Improve migration, superuser, and beat readiness logic Disables automatic migrations for Celery by default to prevent
This commit removes `.env.local` since all it's content was redundant with `.env`. Updated documentation and usage in scripts
…int scripts. Moving files to Docker directory for order
Co-authored-by: Felipe Quesada <felipe.quesadaparada@ucr.ac.cr>
…mmendations Co-authored-by: Felipe Quesada <felipe.quesadaparada@ucr.ac.cr>
Co-authored-by: Felipe Quesada <felipe.quesadaparada@ucr.ac.cr>
Co-authored-by: Felipe Quesada <felipe.quesadaparada@ucr.ac.cr>
…cript Co-authored-by: Felipe Quesada <felipe.quesadaparada@ucr.ac.cr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the Docker-based development and production setup for the Django project. The main focus is on simplifying environment variable management, improving the reliability of migrations and superuser creation, and updating dependencies for better security and compatibility.
Key changes include:
Docker and Environment Configuration
.env.local.exampleand all references to.env.localin Docker Compose files to simplify environment variable management and reduce confusion between environments. Now only.env,.env.dev, and.env.prodare used.Dockerfilefrom3.12-slimto3.14-slimfor better performance and support.postgis/postgis:16-3.4andredis:8-alpinerespectively for improved security and features.Database and Redis Handling
DATABASE_URLconstruction logic indocker-entrypoint.shto handle cases where the database password may be missing, avoiding malformed URLs.REDIS_HOSTandREDIS_PORTsettings to.env.prodand Docker Compose files for consistency.Migrations and Superuser Management
RUN_MAKEMIGRATIONSandMIGRATE_ON_CELERYenvironment variables to control when migrations and makemigrations are run, reducing the risk of race conditions and unnecessary migration attempts. By default, makemigrations is disabled except when explicitly enabled.django_celery_beattables exist before starting the beat process.CREATE_SUPERUSER(default enabled in development), using environment variables for username, password, and email, and using the standardcreatesuperusercommand for better compatibility.Miscellaneous
bucr.jsontogtfs.json, reflecting updated project requirements.dev.shand color tweaks inprod.sh.These changes should make local and production setups more robust, predictable, and easier to maintain.