Sourcemaps emulator#230
Open
ciriousjoker wants to merge 2 commits into
Open
Conversation
ciriousjoker
commented
Apr 13, 2024
ciriousjoker
commented
- Follow up for Add sourcemaps & emulator debugging support #166
simondotm
reviewed
Apr 20, 2024
Comment on lines
+9
to
+15
| import { names } from '@nx/devkit' | ||
| import { readJson, runNxCommandAsync } from '@nx/plugin/testing' | ||
|
|
||
| const NPM_SCOPE = '@proj' | ||
|
|
||
| export interface ProjectData { | ||
| name: string |
Owner
There was a problem hiding this comment.
@ciriousjoker the e2e CI isn't passing atm. I don't think your fork is in sync with the latest, since this module is now just a barrel export.
Everything else apart from this looks good, so the simplest fix would be to revert modifications in just this file for this PR?
Author
There was a problem hiding this comment.
@simondotm Sorry for taking so long, I've moved the changes I made to the old file to the new location. I just added --inspect-functions there
ciriousjoker
force-pushed
the
sourcemaps-emulator
branch
from
7a37474 to
cd1e51a
Compare
Author
|
@simondotm any news? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.