Skip to content

i18n#378

Draft
nossila wants to merge 12 commits into
masterfrom
feature/i18n
Draft

i18n#378
nossila wants to merge 12 commits into
masterfrom
feature/i18n

Conversation

@nossila

@nossila nossila commented May 28, 2026

Copy link
Copy Markdown
Member

No description provided.

@changeset-bot

changeset-bot Bot commented May 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 81a1a03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a501a1c7-ba59-4656-bb42-35757d22e943

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/i18n

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

nossila and others added 9 commits May 28, 2026 18:54
Following FormatJS best practices, added defaultMessage inline with all
message IDs to improve maintainability and developer experience.

Changes:
- CommentCreate: Added defaultMessage "Comment..." to placeholder
- useCommentOptions: Added defaultMessage to all action labels
  - "Share Comment"
  - "Pin Comment" / "Unpin Comment"
  - "Edit Comment"
- CommentsList: Added defaultMessage "loading more comments" to aria-label
- CommentReplyButton: Added defaultMessage to aria-labels with commentId param
- CommentsReplies: Added defaultMessage "Show more replies ({count})"
- CommentPinnedBadge: Added defaultMessage "Pinned"

Benefits per FormatJS documentation:
- Messages colocated with usage become self-managed
- Messages are highly contextual and visible to developers
- Better toolchain integration for syntax validation
- No need to look up IDs in separate JSON files during development

The JSON locale files still provide translations for other languages.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
nossila and others added 3 commits May 29, 2026 01:27
Add the settings.* catalog (menu title, settings tabs, and the preferences
form strings) to all three locale files so pt/es no longer fall back to the
English defaultMessage at runtime.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mirrors the new server-backed User.timezone field so consumers can read and
update the user's timezone alongside preferredLanguage.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Jun 1, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant