Skip to content

Conversation

@Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Jan 5, 2026

Throughout our application we have color="warn" 3 times, and color="accent" 11 times. Unfortunately these and other places that would normally use the accent colors do not actually use them since the upgrade to the Material 3 theming system. We should probably find a new way to apply accent colors, but in the meantime it seems we should apply it where we intended to apply it.

Hopefully storybook will show us whether this is actually a good change to make.


This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.82%. Comparing base (dd2b2cb) to head (25a2bfc).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3621   +/-   ##
=======================================
  Coverage   82.82%   82.82%           
=======================================
  Files         610      610           
  Lines       37414    37414           
  Branches     6152     6128   -24     
=======================================
  Hits        30987    30987           
  Misses       5494     5494           
  Partials      933      933           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is not right. On the settings page the checkboxes and radio buttons use the accent colour as the default.
image.png

@RaymondLuong3 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Nateowami).

@RaymondLuong3 RaymondLuong3 self-assigned this Jan 6, 2026
@Nateowami
Copy link
Collaborator Author

@RaymondLuong3 That's what they always used to do. It's a recent thing that they aren't green.

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I don't remember these ever being the accent colour. Hey, now you would be able to use the "warn" colour on the settings page for the delete this project button.

@RaymondLuong3 made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Nateowami).

@Nateowami
Copy link
Collaborator Author

@RaymondLuong3 You're marked as the assignee on this PR but haven't approved or requested changes. Is that intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants