-
-
Notifications
You must be signed in to change notification settings - Fork 5
Fix Material non-primary themes #3621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3621 +/- ##
=======================================
Coverage 82.82% 82.82%
=======================================
Files 610 610
Lines 37414 37414
Branches 6152 6128 -24
=======================================
Hits 30987 30987
Misses 5494 5494
Partials 933 933 ☔ View full report in Codecov by Sentry. |
RaymondLuong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is not right. On the settings page the checkboxes and radio buttons use the accent colour as the default.
@RaymondLuong3 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Nateowami).
|
@RaymondLuong3 That's what they always used to do. It's a recent thing that they aren't green. |
RaymondLuong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah, I don't remember these ever being the accent colour. Hey, now you would be able to use the "warn" colour on the settings page for the delete this project button.
@RaymondLuong3 made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Nateowami).
|
@RaymondLuong3 You're marked as the assignee on this PR but haven't approved or requested changes. Is that intentional? |

Throughout our application we have
color="warn"3 times, andcolor="accent"11 times. Unfortunately these and other places that would normally use the accent colors do not actually use them since the upgrade to the Material 3 theming system. We should probably find a new way to apply accent colors, but in the meantime it seems we should apply it where we intended to apply it.Hopefully storybook will show us whether this is actually a good change to make.
This change is