Revive macOS builds#1746
Draft
Schuyler Eldridge (seldridge) wants to merge 6 commits into
Draft
Conversation
This revives macOS build support. This is primarily possible because of two things: 1. The local job cache was dropped [[1]] 2. C++17 support is enabled With thi spatch, I have to make no changes on macOS to get it to build other than going through the slightly onerous hoops to get macFUSE working. @dtzSiFive did a bunch of this work independently. What is here is primarily from an AI-assisted branch that I revied after the job cache was removed. [1]: b0de416 Co-authored-by: Will Dietz <will.dietz@sifive.com> Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revives macOS build support. This is primarily possible because of two things:
With thi spatch, I have to make no changes on macOS to get it to build other than going through the slightly onerous hoops to get macFUSE working.
Will Dietz (@dtzSiFive) did a bunch of this work independently. What is here is primarily from an AI-assisted branch that I revied after the job cache was removed.
I've tested this by running
makeon macOS and it works. For this to really get locked in, it should be in CI. My motivation for this is that I'd like to actually use wake for other projects. However, this is very difficult unless it has at least macOS support. (I'm not asking for native Windows. 😉)