Blake3 migration#1740
Conversation
| $(patsubst %.cpp,%.o,$(COMMON_CPP)) $(patsubst %.c,%.o,$(COMMON_C)) | ||
|
|
||
| # BLAKE3 platform detection | ||
| UNAME_M := $(shell uname -m) |
There was a problem hiding this comment.
This makefile, and the blake3.wake file, were changed according to the documentation on how to build for each platform: https://github.com/BLAKE3-team/BLAKE3/tree/master/c#building-manually
| #define WAKE_SCHEMA_H | ||
|
|
||
| #define SCHEMA_VERSION "9" | ||
| #define SCHEMA_VERSION "10" |
There was a problem hiding this comment.
Even if the schema wasn't manually updated, i will still consider this a bump to the schema version since the underlying file hashes has changed
| {9, 10, | ||
| [](sqlite3* db) -> bool { | ||
| (void)db; // unused | ||
| std::cerr << std::endl; |
There was a problem hiding this comment.
I don't think users can really migrate to this newest DB version, without starting a fresh wake.db
There was a problem hiding this comment.
Certainly not if we want to drop blake2 support :).
We /could/ support this if we wanted -- promote to one of the schemes (maybe like SRI hashes) that specifies the hash kind with the hash value/result, but I'm on board with the break. Just saying it's not necessary, but also without costs of course.
Abrar Quazi (AbrarQuazi)
requested review from
Sam May (ag-eitilt),
Will Dietz (dtzSiFive) and
Nathan Graybeal (ngraybeal)
Will Dietz (dtzSiFive)
left a comment
Will Dietz (dtzSiFive)
left a comment
There was a problem hiding this comment.
LGTM, nice!
I did not review the contents of the blake3 directory, I assume it was almost entirely (other than blake3.wake) imported from a release tarball (or equivalent).
Do we want / need to sort out how to enable vector support for x86_64 (probably essentially all of our users), conceivably dynamically detecting feature support?
Nathan Graybeal (ngraybeal)
left a comment
Nathan Graybeal (ngraybeal)
left a comment
There was a problem hiding this comment.
LGTM
3 participants
Updates our hashing algorithm from blake2b to blake3, which should lead to faster hashing performance: https://github.com/BLAKE3-team/BLAKE3. This will bring wake and RSC to utilize the same hashing algorithm.
Blake3 C and header files were taken from https://github.com/BLAKE3-team/BLAKE3/tree/master/c version: 1.8.2