Skip to content

connectSPI and connectUART no longer require entire dut#50

Merged
Henry Cook (hcook) merged 1 commit into
masterfrom
connect-methods
Dec 12, 2018
Merged

connectSPI and connectUART no longer require entire dut#50
Henry Cook (hcook) merged 1 commit into
masterfrom
connect-methods

Conversation

@hcook
Copy link
Copy Markdown
Contributor

@hcook Henry Cook (hcook) commented Dec 12, 2018

It's more future-proof to operate on the specific bundle and param instances required instead of expecting a specific trait of a specific hierarchy level.

Future work:

  • eliminate further dependencies on similar traits (Debug (Make some of the connector methods more flexible #41), XilinxMIG)
  • standardize dut_clock and dut_reset so they're always available, or some other way to make sure that the right clock is used for each peripheral's connection wiring

@hcook
Copy link
Copy Markdown
Contributor Author

Megan Wachs (@mwachs5) I realized after I did this that it partially conflicts with #41, sorry. I made changes in more shells to fewer peripherals

@hcook Henry Cook (hcook) merged commit 3d47385 into master Dec 12, 2018
@mwachs5
Copy link
Copy Markdown
Contributor

Megan Wachs (mwachs5) commented Dec 12, 2018

No, that’s great. #41 was a hackier version of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants