feat(summary-row): support providing custom animation class#711
feat(summary-row): support providing custom animation class#711chintankavathia wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for customizing enter and leave animations on the datatable summary row by adding summaryRowAnimateEnter and summaryRowAnimateLeave inputs to the main datatable component and passing them down to the summary row component. However, the current implementation uses host bindings in DataTableSummaryRowComponent to target [animate.enter] and [animate.leave] directives, which Angular does not support on the same host element. The reviewer recommends binding these animation directives directly to the <datatable-summary-row> element within the parent template (body.component.ts) instead, which also allows for the removal of the redundant inputs in DataTableSummaryRowComponent.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
Adds new inputs to let consumers provide custom CSS classes for summary-row enter/leave animations, wiring them through the datatable -> body -> summary-row component chain.
Changes:
- Introduces
summaryRowAnimateEnter/summaryRowAnimateLeaveinputs onDatatableComponent. - Forwards these inputs through
DataTableBodyComponenttoDataTableSummaryRowComponent. - Applies the provided values to the summary-row host via
[animate.enter]/[animate.leave]bindings.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/ngx-datatable/src/lib/components/datatable.component.ts | Adds new public inputs for configuring summary-row enter/leave animation classes. |
| projects/ngx-datatable/src/lib/components/datatable.component.html | Passes the new inputs down to the body component. |
| projects/ngx-datatable/src/lib/components/body/body.component.ts | Adds corresponding inputs and forwards them to the summary-row component instances (top/bottom). |
| projects/ngx-datatable/src/lib/components/body/summary/summary-row.component.ts | Adds animateEnter/animateLeave inputs and binds them on the component host. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added `summaryRowAnimateEnter` and `summaryRowAnimateLeave` input which can be used to provide custom class for angular's `[animate.enter]` and `[animate.leave]` transitions on summary row.
10e56b6 to
a7b9f32
Compare
added
summaryRowAnimateEnterandsummaryRowAnimateLeaveinput which can be used to provide custom class for angular's[animate.enter]and[animate.leave]transitions on summary row.What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: