Skip to content

feat(summary-row): support providing custom animation class#711

Open
chintankavathia wants to merge 1 commit into
siemens:mainfrom
chintankavathia:feat/summary-row/animation
Open

feat(summary-row): support providing custom animation class#711
chintankavathia wants to merge 1 commit into
siemens:mainfrom
chintankavathia:feat/summary-row/animation

Conversation

@chintankavathia

Copy link
Copy Markdown
Member

added summaryRowAnimateEnter and summaryRowAnimateLeave input which can be used to provide custom class for angular's [animate.enter] and [animate.leave] transitions on summary row.

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@chintankavathia chintankavathia requested a review from a team as a code owner June 11, 2026 08:39

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for customizing enter and leave animations on the datatable summary row by adding summaryRowAnimateEnter and summaryRowAnimateLeave inputs to the main datatable component and passing them down to the summary row component. However, the current implementation uses host bindings in DataTableSummaryRowComponent to target [animate.enter] and [animate.leave] directives, which Angular does not support on the same host element. The reviewer recommends binding these animation directives directly to the <datatable-summary-row> element within the parent template (body.component.ts) instead, which also allows for the removal of the redundant inputs in DataTableSummaryRowComponent.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread projects/ngx-datatable/src/lib/components/body/summary/summary-row.component.ts Outdated
Comment thread projects/ngx-datatable/src/lib/components/body/body.component.ts Outdated
Comment thread projects/ngx-datatable/src/lib/components/body/body.component.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new inputs to let consumers provide custom CSS classes for summary-row enter/leave animations, wiring them through the datatable -> body -> summary-row component chain.

Changes:

  • Introduces summaryRowAnimateEnter / summaryRowAnimateLeave inputs on DatatableComponent.
  • Forwards these inputs through DataTableBodyComponent to DataTableSummaryRowComponent.
  • Applies the provided values to the summary-row host via [animate.enter] / [animate.leave] bindings.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
projects/ngx-datatable/src/lib/components/datatable.component.ts Adds new public inputs for configuring summary-row enter/leave animation classes.
projects/ngx-datatable/src/lib/components/datatable.component.html Passes the new inputs down to the body component.
projects/ngx-datatable/src/lib/components/body/body.component.ts Adds corresponding inputs and forwards them to the summary-row component instances (top/bottom).
projects/ngx-datatable/src/lib/components/body/summary/summary-row.component.ts Adds animateEnter/animateLeave inputs and binds them on the component host.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread projects/ngx-datatable/src/lib/components/body/summary/summary-row.component.ts Outdated
added `summaryRowAnimateEnter` and `summaryRowAnimateLeave` input which can be used to provide custom class for angular's `[animate.enter]` and `[animate.leave]` transitions on summary row.
@chintankavathia chintankavathia force-pushed the feat/summary-row/animation branch from 10e56b6 to a7b9f32 Compare June 11, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants