Skip to content

build: install playwright-cli skill#678

Open
spike-rabbit wants to merge 1 commit into
mainfrom
build/playwright-cli-skill
Open

build: install playwright-cli skill#678
spike-rabbit wants to merge 1 commit into
mainfrom
build/playwright-cli-skill

Conversation

@spike-rabbit

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

No AI skills.

What is the new behavior?

Playwright-cli skill.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Very usefull to allow models inspecting the DOM at runtime.

@spike-rabbit spike-rabbit requested a review from a team as a code owner April 28, 2026 13:37

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive documentation for the playwright-cli tool, including a main skill file and several detailed reference guides covering session management, storage state, request mocking, and video recording. The review feedback suggests correcting outdated npx flags, clarifying remote debugging instructions for Chrome, ensuring consistent .gitignore patterns for authentication state files, and using placeholders for dynamic timestamps in examples.

Comment thread .agents/skills/playwright-cli/SKILL.md
Comment thread .agents/skills/playwright-cli/SKILL.md
Comment thread .agents/skills/playwright-cli/references/session-management.md
Comment thread .agents/skills/playwright-cli/references/storage-state.md

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Playwright CLI “skill” under .agents/ to help models drive/inspect web pages via Playwright at runtime, and updates ignore rules to avoid committing/generated formatting for agent and CLI artifacts.

Changes:

  • Add new .agents/skills/playwright-cli skill documentation (SKILL.md + reference guides).
  • Ignore .agents in Prettier formatting.
  • Ignore .playwright-cli runtime artifacts in Git.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
.prettierignore Excludes .agents from Prettier formatting runs.
.gitignore Ignores /.playwright-cli/ generated artifacts.
.agents/skills/playwright-cli/SKILL.md Adds the main skill definition and command/reference overview.
.agents/skills/playwright-cli/references/video-recording.md Adds guidance and examples for video recording workflows.
.agents/skills/playwright-cli/references/tracing.md Adds tracing usage and best practices documentation.
.agents/skills/playwright-cli/references/test-generation.md Adds documentation on generating tests from CLI interactions.
.agents/skills/playwright-cli/references/storage-state.md Adds guidance for cookies/storage state management.
.agents/skills/playwright-cli/references/session-management.md Adds documentation for multi-session usage patterns.
.agents/skills/playwright-cli/references/running-code.md Adds run-code examples for advanced Playwright usage.
.agents/skills/playwright-cli/references/request-mocking.md Adds request routing/mocking examples.
.agents/skills/playwright-cli/references/playwright-tests.md Adds guidance for running/debugging Playwright tests with the CLI.
.agents/skills/playwright-cli/references/element-attributes.md Adds attribute inspection examples via eval.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .agents/skills/playwright-cli/SKILL.md
Comment thread .agents/skills/playwright-cli/references/running-code.md
Comment thread .agents/skills/playwright-cli/references/request-mocking.md
Comment thread .agents/skills/playwright-cli/references/request-mocking.md
Comment thread .agents/skills/playwright-cli/references/tracing.md
Comment thread .agents/skills/playwright-cli/references/video-recording.md
@spike-rabbit

Copy link
Copy Markdown
Member Author

resolve all comemtns as the skill is generated

@fh1ch fh1ch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spike-rabbit thanks a lot for the PR. The changes look good, just some general questions/inputs from my end.

Back to you 🏓

Comment thread .prettierignore

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason the agent skills are exempt from Prettier? AFAIK, it shouldn't hurt any agent if the files also adhere to our general style. Considering that we might want to update/tune them, having no formatting might become a pain further down.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind loosing two-three words how these files were generated or from where they were copied? The PR description is more than spares and we should have a strategy how to update/further add them.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the plan regarding usage? Shall we also add some references to the main readme, so other people know how to use it too?

@spike-rabbit spike-rabbit force-pushed the build/playwright-cli-skill branch from 30a0f46 to 0853b0d Compare May 21, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants