build: install playwright-cli skill#678
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive documentation for the playwright-cli tool, including a main skill file and several detailed reference guides covering session management, storage state, request mocking, and video recording. The review feedback suggests correcting outdated npx flags, clarifying remote debugging instructions for Chrome, ensuring consistent .gitignore patterns for authentication state files, and using placeholders for dynamic timestamps in examples.
a9dd0ce to
30a0f46
Compare
There was a problem hiding this comment.
Pull request overview
Adds a Playwright CLI “skill” under .agents/ to help models drive/inspect web pages via Playwright at runtime, and updates ignore rules to avoid committing/generated formatting for agent and CLI artifacts.
Changes:
- Add new
.agents/skills/playwright-cliskill documentation (SKILL.md + reference guides). - Ignore
.agentsin Prettier formatting. - Ignore
.playwright-cliruntime artifacts in Git.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| .prettierignore | Excludes .agents from Prettier formatting runs. |
| .gitignore | Ignores /.playwright-cli/ generated artifacts. |
| .agents/skills/playwright-cli/SKILL.md | Adds the main skill definition and command/reference overview. |
| .agents/skills/playwright-cli/references/video-recording.md | Adds guidance and examples for video recording workflows. |
| .agents/skills/playwright-cli/references/tracing.md | Adds tracing usage and best practices documentation. |
| .agents/skills/playwright-cli/references/test-generation.md | Adds documentation on generating tests from CLI interactions. |
| .agents/skills/playwright-cli/references/storage-state.md | Adds guidance for cookies/storage state management. |
| .agents/skills/playwright-cli/references/session-management.md | Adds documentation for multi-session usage patterns. |
| .agents/skills/playwright-cli/references/running-code.md | Adds run-code examples for advanced Playwright usage. |
| .agents/skills/playwright-cli/references/request-mocking.md | Adds request routing/mocking examples. |
| .agents/skills/playwright-cli/references/playwright-tests.md | Adds guidance for running/debugging Playwright tests with the CLI. |
| .agents/skills/playwright-cli/references/element-attributes.md | Adds attribute inspection examples via eval. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
resolve all comemtns as the skill is generated |
fh1ch
left a comment
There was a problem hiding this comment.
@spike-rabbit thanks a lot for the PR. The changes look good, just some general questions/inputs from my end.
Back to you 🏓
There was a problem hiding this comment.
Any reason the agent skills are exempt from Prettier? AFAIK, it shouldn't hurt any agent if the files also adhere to our general style. Considering that we might want to update/tune them, having no formatting might become a pain further down.
There was a problem hiding this comment.
Would you mind loosing two-three words how these files were generated or from where they were copied? The PR description is more than spares and we should have a strategy how to update/further add them.
There was a problem hiding this comment.
What's the plan regarding usage? Shall we also add some references to the main readme, so other people know how to use it too?
30a0f46 to
0853b0d
Compare
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
No AI skills.
What is the new behavior?
Playwright-cli skill.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Very usefull to allow models inspecting the DOM at runtime.