Skip to content

fix(summary-row): don't show checkbox with summary row #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chintankavathia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(summary-row): don't show checkbox with summary row #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions projects/ngx-datatable/src/lib/components/body/summary/summary-row.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,20 @@ describe('DataTableSummaryRowComponent', () => {
});
});

describe('Checkbox', () => {
it('should not render checkbox in summary row even if a column is checkboxable', async () => {
const checkboxableColumns = toInternalColumn([
{ prop: 'col1', checkboxable: true },
{ prop: 'col2' }
]);
componentRef.setInput('columns', checkboxableColumns);
componentRef.setInput('rows', rows);

expect(await harness.hasSummaryRow()).toBe(true);
expect(await harness.getCheckboxCount()).toBe(0);
});
});

describe('Computing', () => {
beforeEach(() => {
componentRef.setInput('columns', columns);
Expand Down
1 change: 1 addition & 0 deletions projects/ngx-datatable/src/lib/components/body/summary/summary-row.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export class DataTableSummaryRowComponent {
protected readonly _internalColumns = computed(() => {
return this.columns().map(col => ({
...col,
checkboxable: false,
cellTemplate: col.summaryTemplate
}));
Comment thread
chintankavathia marked this conversation as resolved.
});
Expand Down
6 changes: 6 additions & 0 deletions projects/ngx-datatable/src/lib/components/body/summary/testing/summary.harness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export class SummaryHarness extends ComponentHarness {

private summaryRowCells = this.locatorForAll('datatable-body-cell');
private summaryRow = this.locatorForOptional('datatable-body-row');
private checkboxes = this.locatorForAll('input[type="checkbox"]');

async getSummaryRowCellText(index: number): Promise<string> {
const cells = await this.summaryRowCells();
Expand All @@ -15,4 +16,9 @@ export class SummaryHarness extends ComponentHarness {
const row = await this.summaryRow();
return !!row;
}

async getCheckboxCount(): Promise<number> {
const checkboxes = await this.checkboxes();
return checkboxes.length;
}
}
Loading