Skip to content

Remove batching from event based decryption triggers #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
konradkonrad wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove batching from event based decryption triggers #700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions rolling-shutter/keyperimpl/shutterservice/newblock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,8 @@ func (kpr *Keyper) createTriggersFromIdentityRegisteredEvents(
if identityPreimages[event.Eon] == nil {
identityPreimages[event.Eon] = make([]identitypreimage.IdentityPreimage, 0)
}
identityPreimages[event.Eon] = append(identityPreimages[event.Eon], identitypreimage.IdentityPreimage(event.Identity))
identityPreimages[event.Eon] = append(identityPreimages[event.Eon],
identitypreimage.IdentityPreimage(event.Identity))

if _, exists := lastEonBlock[event.Eon]; !exists {
lastEonBlock[event.Eon] = eon.ActivationBlockNumber
Expand Down Expand Up @@ -269,19 +270,15 @@ func (kpr *Keyper) prepareEventBasedTriggers(ctx context.Context) ([]epochkghand
continue
}

identities := []identitypreimage.IdentityPreimage{}
// issue 698: here we "unbatch" all event based decryption triggers and create one broker event per identity
for _, firedTrigger := range firedTriggers {
identities = append(identities, firedTrigger.Identity)
identityPreimage := []identitypreimage.IdentityPreimage{firedTrigger.Identity}
decryptionTrigger := epochkghandler.DecryptionTrigger{
BlockNumber: uint64(eonStruct.ActivationBlockNumber),
IdentityPreimages: identityPreimage,
}
decryptionTriggers = append(decryptionTriggers, decryptionTrigger)
}

sortedIdentityPreimages := sortIdentityPreimages(identities)

decryptionTrigger := epochkghandler.DecryptionTrigger{
BlockNumber: uint64(eonStruct.ActivationBlockNumber),
IdentityPreimages: sortedIdentityPreimages,
}

decryptionTriggers = append(decryptionTriggers, decryptionTrigger)
}
return decryptionTriggers, nil
}
Expand Down