Skip to content

SG-21701 Replace instances of Shotgun strings in .py files in all tk-…#142

Open
zamu5 wants to merge 2 commits intomasterfrom
SG-21701-replace_shotgun_instances
Open

SG-21701 Replace instances of Shotgun strings in .py files in all tk-…#142
zamu5 wants to merge 2 commits intomasterfrom
SG-21701-replace_shotgun_instances

Conversation

@zamu5
Copy link
Copy Markdown

@zamu5 zamu5 commented Mar 26, 2021

…* repos with "SG"

@zamu5 zamu5 requested a review from thebeeland March 26, 2021 22:17
Copy link
Copy Markdown

@hound hound Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link
Copy Markdown

@hound hound Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link
Copy Markdown

@hound hound Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link
Copy Markdown

@hound hound Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link
Copy Markdown

@hound hound Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link
Copy Markdown

@hound hound Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2021

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.13%. Comparing base (fdd309d) to head (f340f26).
⚠️ Report is 54 commits behind head on master.

Files with missing lines Patch % Lines
...ti_publish2/progress/ui/progress_details_widget.py 0.00% 2 Missing ⚠️
...ti_publish2/api/plugins/publish_plugin_instance.py 0.00% 1 Missing ⚠️
python/tk_multi_publish2/dialog.py 0.00% 1 Missing ⚠️
python/tk_multi_publish2/ui/dialog.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fdd309d) and HEAD (f340f26). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (fdd309d) HEAD (f340f26)
10 8
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #142       +/-   ##
===========================================
- Coverage   82.15%   39.13%   -43.03%     
===========================================
  Files          61       61               
  Lines        4730     4730               
===========================================
- Hits         3886     1851     -2035     
- Misses        844     2879     +2035     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tests/test_gui.py Outdated
Comment thread tests/test_gui.py Outdated
Comment thread tests/test_gui.py Outdated
Comment thread tests/test_gui.py Outdated
Comment thread tests/test_gui.py Outdated
Comment thread tests/test_gui.py
app_dialog.root["collected items tree"].outlineitems[
"Publish to Shotgun with items"
][1].mouseClick()
app_dialog.root["collected items tree"].outlineitems["Publish to Shotgun with items"][
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@zamu5 zamu5 requested a review from eshokrgozar May 12, 2021 18:16
Copy link
Copy Markdown
Contributor

@eshokrgozar eshokrgozar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how deep you were asked to take this so let me know if these were left out on purpose. But there are a few Shotgun mentions that haven't been changed. Here are some examples (there are more):

return "Publish to Shotgun"

"description": "Upload content to Shotgun?",

- name: Publish to Shotgun

There are also logger messages mentioning Shotgun. Are we leaving these for now? Again, just an example:

self.logger.warn(

Lastly. The tests are failing on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants