fix: acceptance test expected entity counts#143
Merged
Malte Janz (MalteJanz) merged 1 commit intofeature/migration-logging-refactorfrom Feb 27, 2026
Merged
Conversation
Malte Janz (MalteJanz)
requested review from
a team,
Simon Fiebranz (CR0YD),
Dennis Garding (DennisGarding),
Susanne Hartung (ennasus4sun),
Jozsef Damokos (jozsefdamokos),
Lars Kemper (larskemper) and
Nikolas Evers (vintagesucks)
and removed request for
a team
Nikolas Evers (vintagesucks)
approved these changes
Feb 27, 2026
Simon Fiebranz (CR0YD)
approved these changes
Feb 27, 2026
Malte Janz (MalteJanz)
merged commit c26f0ad
into
feature/migration-logging-refactor
7 checks passed
Malte Janz (MalteJanz)
deleted the
fix/acceptance-test-expected-entity-counts
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the shopware core added a CMS page, likely here:
shopware/shopware#14362
And because we compare absolute entity counts after the migration, that counter for
cms_pagechanged and causing a failing acceptance pipeline for us:https://github.com/shopware/SwagMigrationAssistant/actions/runs/22477261457/job/65107811395
For now I adjusted the count, but for the future we likely want to consider comparing relative numbers (e.g. fetching counts before and after the migration) to be more resistant against such changes. I created an issue for that here:
shopware/shopware#15245