feat(actual) Resolvers for Finance: show available room for income an…#28
Open
rajakvk wants to merge 1 commit into
Open
feat(actual) Resolvers for Finance: show available room for income an…#28rajakvk wants to merge 1 commit into
rajakvk wants to merge 1 commit into
Conversation
…d expense for each category
souvikbasu
requested changes
Dec 29, 2021
| * @returns workItems for Income and Expense Categories | ||
| */ | ||
| async getActualsWorkItems(v1AccessToken,v2AccessToken) { | ||
| return this.get(`stats/total-actual-amount-workitemwise?startdate=20211201&enddate=20211231`, null, { |
Member
There was a problem hiding this comment.
It takes hard coded dates. Please use startDate and endDate params instead
| } | ||
| /** | ||
| * Get actual amount for Income and Expense Categories | ||
| * @param v1AccessToken |
| } | ||
| /** | ||
| * Get planned amount for Income and Expense Categories | ||
| * @param v1AccessToken |
Member
There was a problem hiding this comment.
Remove tokens from API doc comment
| async getPlannedWorkItems(v1AccessToken,v2AccessToken, month) { | ||
| console.log('Access Token1:', v1AccessToken); | ||
| console.log('Access Token2:', v2AccessToken); | ||
| return this.get(`stats/total-planned-amount-workitemwise?startmonth=202112&endmonth=202112`, null, { |
Member
There was a problem hiding this comment.
It takes hard coded dates. Please use startDate and endDate params instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d expense for each category
Closes #27
Original feature request
shoonyatech/wallora.com#109