Validate package name in banEmptyJavaFiles#23
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Bump Java source/target to 17 to enable records; add CompilationUnitInfo record (packageName + typeNames) and update TLDParser.parse() to return it. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Add PackageDeclarationState to extract the package name from Java source, returning CompilationUnitInfo instead of List<String>. Update AbstractTLDParser and stub other parsers to compile cleanly. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Add PACKAGE lexer token and packageDeclaration rule to JavaTLD.g4; update AntlrTLDParser.parse() to extract and return the package name via CompilationUnitInfo. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
banEmptyJavaFilesto also flag Java files whosepackagedeclaration doesn't match their directory path relative to the source rootCompilationUnitInforecord (package name + type names) and updates all four parser implementations (RecursiveDescentTLDParser,RegexBasedTLDParser,AntlrTLDParser,JavaParserTLDParser) to capture the package declarationError message format
Test plan
mvn test— 27 unit tests pass (parsers, EmptyJavaFileAnalyzer, existing rules)JAVA_HOME=$(/usr/libexec/java_home -v 21) mvn verify— all 8 integration tests pass including newfail-ban-empty-java-files-wrong-packageITmaven.compiler.source/targetto 17 (required for records)🤖 Generated with Claude Code