Skip to content

Pouches fit in Vests#6133

Open
firebudgy wants to merge 1 commit intoshiptest-ss13:masterfrom
firebudgy:pouch2
Open

Pouches fit in Vests#6133
firebudgy wants to merge 1 commit intoshiptest-ss13:masterfrom
firebudgy:pouch2

Conversation

@firebudgy
Copy link
Copy Markdown
Contributor

About The Pull Request

Pouches now fit in vests, allowing for more flexibility. Adjusts nesting code to account for exception lists as well.

Why It's Good For The Game

Turns out, even trying to make pouches work for pockets - that space is valuable enough that people tend to stick the same few items in there, with oxygen tanks taking up a mandatory slot.

This should add flexibility to people's loadouts and make them consider a bit more what they do with their vests - and allow for customization. And snack pouches. Everyone needs one of those.

Changelog

🆑
balance: Pouches fit in vests now.
code: Storage nesting code now accounts for exception lists, in the specific cases this would be relevant.
/:cl:

@firebudgy firebudgy requested a review from a team as a code owner April 5, 2026 11:46
@github-actions github-actions bot added the Code change Watch something violently break. label Apr 5, 2026
@thgvr
Copy link
Copy Markdown
Member

thgvr commented Apr 5, 2026

this is almost certainly not a good change

@Overteh
Copy link
Copy Markdown
Contributor

Overteh commented Apr 5, 2026

Would be great to make a separate storage slot dedicated for small oxygen tank. Unfortutanelly, don't know the code much to do it myself.

@DIB-DOG
Copy link
Copy Markdown
Contributor

DIB-DOG commented Apr 5, 2026

Would be great to make a separate storage slot dedicated for small oxygen tank. Unfortutanelly, don't know the code much to do it myself.

Would have to disagree somewhat there? Having to sacrifice a slot or decide whether or not you’re gonna bring something is a good thing IMO and makes operations in a no-air environment actually feel bulky.

Besides, air can fit on your belt, suit storage, back, or either of your two pockets. If you can’t make air fit in at least one of those, you should probably re-evaluate how much you’re carrying.

@DIB-DOG
Copy link
Copy Markdown
Contributor

DIB-DOG commented Apr 5, 2026

this is almost certainly not a good change

I was worried at first when I first read it too, but it’s not going into webbing/vests on your belt slot, which could admittedly lead to a pretty crazy nested storage situation.

Since it’s going into your actual armor vest’s storage, and those only have 2 slots total, I don’t think this is too outrageous. It makes sense to be able to attach them to the armor and shouldn’t be too OP IMO.

@Overteh
Copy link
Copy Markdown
Contributor

Overteh commented Apr 5, 2026

makes it a storage in 2 clicks away, also have to keep equipment doll open, I think it will be bulky to use

@Overteh
Copy link
Copy Markdown
Contributor

Overteh commented Apr 5, 2026

Would be great to make a separate storage slot dedicated for small oxygen tank. Unfortutanelly, don't know the code much to do it myself.

Would have to disagree somewhat there? Having to sacrifice a slot or decide whether or not you’re gonna bring something is a good thing IMO and makes operations in a no-air environment actually feel bulky.

Besides, air can fit on your belt, suit storage, back, or either of your two pockets. If you can’t make air fit in at least one of those, you should probably re-evaluate how much you’re carrying.

Then I can just sacrifice my flesh and become IPC to have my pocket free. On station builds, you don't need to use oxygen tank and flashlight most of time, they are tools for emergency situations, unlike shiptest where you need them 90% of the time. We have pocket flashlight replacements like rail light and helmet mount, now we just need something for oxygen tanks. I would prefer to have a further discussion not in the comments of this pull request.

@thgvr
Copy link
Copy Markdown
Member

thgvr commented Apr 5, 2026

what we should be looking at more here is stuff like having oxygen tanks be inserted into hardsuits to function

@Apogee-dev
Copy link
Copy Markdown
Contributor

Apogee-dev commented Apr 9, 2026

It wouldn't hurt if oxygen tanks could function out of specific additional storage slots, maybe? Vest/jacket pockets come to mind. Those aren't exactly competitive, as storage space goes.

@firebudgy
Copy link
Copy Markdown
Contributor Author

It wouldn't hurt if oxygen tanks could function out of specific additional storage slots, maybe? Vest/jacket pockets come to mind. Those aren't exactly competitive, as storage space goes.

If you can figure out how to do it. Both I and Zimon tried.

@thgvr
Copy link
Copy Markdown
Member

thgvr commented Apr 9, 2026

something i think could work well is a mask of some sort that accepts an air tank and functions off of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code change Watch something violently break.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants