feat: apply shinzohub client library to Studio#227
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
shinzo-studio | 72ca929 | Commit Preview URL Branch Preview URL |
May 22 2026, 01:51 PM |
VanishMax
commented
May 22, 2026
Comment on lines
-161
to
+147
| const tx = await buildDeployTransaction(resolvedView, wasmBytesByStep); | ||
| const bundle = await bundleView(viewDefinition); |
Collaborator
Author
There was a problem hiding this comment.
note: view bundling now comes from lenses package
Comment on lines
-212
to
177
| txHash = await sendTransactionMutateAsync({ | ||
| txHash = await createView(walletClient, { | ||
| account, | ||
| to: tx.to, | ||
| data: tx.data, | ||
| chainId, | ||
| gas, | ||
| gasPrice: gasPriceOverride, | ||
| bundle, | ||
| }); |
Collaborator
Author
There was a problem hiding this comment.
note: sending view registration transaction is now streamlined
VanishMax
added a commit
that referenced
this pull request
May 23, 2026
* feat(shinzohub): create shinzohub client package * fix(shinzohub): replace hex encodings with viem functions * feat: add `getCreatedViewAddress` method * fix(shinzohub): extract shinzo address validation * feat: apply shinzohub client library to Studio (#227) * feat(lenses): add view bundling to lenses package * feat(studio): apply shinzohub package to deploy a view * fix(studio): build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #223
This PR shows how effective
@shinzo/shinzohublibrary can be when applied to real-life use cases.In here, I refactored Shinzo Studio to use this library and removed many complicated lines of code, keeping only the meaning. In short, registering a view now looks like this:
What used to be a complicated bundling and sending transaction task now became just a plain formula.