fix: Check null before use objects and add runOnExecutor#26
Conversation
|
@codex review |
|
@codex review |
There was a problem hiding this comment.
Pull request overview
Fixes an Android crash/hang when finishing a group call by hardening voice-activity observation against null peer/connection objects and adjusting threading to run voice stats polling on the module’s single-thread executor.
Changes:
- Added null checks in
observeVoiceActivity()forPeerConnectionObserverandPeerConnectionbefore use. - Moved voice stats polling work to
ThreadUtils.runOnExecutor()from theTimerthread. - Prevented potential NPE in
peerConnectionDispose()by guardingpco.dispose().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b1128292d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
M-2740 Android: app stuck and then crashes, when finish a group call