feature: setLoggingOptions method#3
Merged
Conversation
Author
|
@codex review |
iosDeveloperDenis
approved these changes
May 22, 2026
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds runtime Meteor logging configuration via
Meteor.setLoggingOptions.Changes
Meteor.setLoggingOptions({ isVerbose, isPrivate, logger }).message:outlogging hook regardless of initialisVerbose, so verbose logging can be enabled afterMeteor.connect.MeteorLoggingOptions.Motivation
Consumers can now enable/disable Meteor logs and switch private/full payload logging while the app is running, without reconnecting and disturbing the current DDP session.
Testing
npm run build✅npm run lint✅Meteor.setLoggingOptionstest ✅npm run test:coveragecurrently fails on existingRandom/Collectiontests because the Node test environment does not expose the expected secure random generator. The failures are unrelated to this logging change.Risk
Low. The behavior change is limited to internal logging configuration. The outgoing message listener is now always attached, but it exits immediately unless
isVerboseis enabled.