Skip to content

Story/m 2605/report user logouts#2

Merged
fmorau merged 5 commits into
masterfrom
story/m-2605/report-user-logouts
Mar 3, 2026
Merged

Story/m 2605/report user logouts#2
fmorau merged 5 commits into
masterfrom
story/m-2605/report-user-logouts

Conversation

@fmorau

@fmorau fmorau commented Jan 22, 2026

Copy link
Copy Markdown

No description provided.

@fmorau fmorau self-assigned this Jan 22, 2026
@fmorau fmorau requested a review from Copilot January 22, 2026 17:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the error reporting for user authentication failures by introducing a standardized LoginFailurePayload type and implementing comprehensive logout tracking. The changes ensure consistent error information is provided when login attempts fail or users are automatically logged out due to authentication issues.

Changes:

  • Introduced LoginFailurePayload type and normalizeLoginFailure function to standardize error reporting
  • Updated KeyStorage interface to enforce async operations with Promise return types
  • Modified authentication flow to properly await async operations and report logout-triggered failures

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/user/User.ts Added login failure normalization, made authentication methods async, and updated error reporting with logout tracking
src/user/Accounts.ts Updated onLoginFailure callback signature to use typed LoginFailurePayload
src/index.ts Exported LoginFailurePayload type for external use
src/Data.ts Changed KeyStorage interface to require Promise return types for all methods
package.json Version bump to 2.28.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/user/User.ts Outdated
Comment thread src/user/User.ts
@fmorau

fmorau commented Jan 22, 2026

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f454004a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/user/User.ts
@fmorau fmorau merged commit 24b3222 into master Mar 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants