upstream#1
Open
Strangerxxx wants to merge 97 commits into
Open
Conversation
* Avoid using wine in WSL * Fix errcheck and stylecheck errors
Close #27
…29) Arch Linux no longer distributes the "obsoleted" libappindicator-sharp package. https://lists.archlinux.org/pipermail/arch-commits/2020-March/722392.html
…(size of exe increased from 13 to 18 MB) Close #33
…ientConfig, retry download with default RootCA. (#39) On Windows x509.SystemCertPool() always returns nil which means that Windows users with NODE_EXTRA_CA_CERTS defined will only get the NODE_EXTRA_CA_CERTS. Therefore, if RootCAs was created, and the download fail, retry with RootCAs as nil to allow Go to figure out the proper CAs. Signed-off-by: Samuel HULTGREN <samuel.hultgren@st.com>
Snapcraft has ignored the target-arch flag, which works in very limited circumstances, with destructive mode. Snapcraft considers it unsupported and will not be fixed in its current form. Recently snapcraft regarded improper usage of this as a hard error instead of silently ignoring, which broke users of app-builder. We reverted that to simply warn, but this fix is to remove its usage from app-builder. If the user is targeting an arch that is not the host arch, error out with a nice message. However, it does require that --arch with `snap` must use the scheme provided by go. If there are a set of supported architecture options somewhere, I can update to ensure that they map to GOARCH. Closes: #40 Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
* feat: proper error handling & fixing a minor bug when parsing hashbang * chore: removing accidental debug statements
…es which declare themselves to use napi (#47)
When a user has one or several `XDG_SPECIAL_DIRS` folders symlinked in their real home folder to elsewhere in their real home folder `desktop-common.sh` will attempt to mv those folders to themselves. Because we are executing this script with `bash -e`, this prevents any Snap with the `home` interface built with these scripts from launching when the user has moved any of their Documents, Pictures, Music, etc. and replaced with a symlink. * guard `mv` calls with test for `is_subpath` to ensure that we're only moving symlinks we created. See related PRs on Snapcraft-desktop-helpers and Snapcraft: * ubuntu/snapcraft-desktop-helpers#220 * canonical/snapcraft#3435 Signed-off-by: Daniel Llewellyn <diddledan@ubuntu.com>
Configures the build so that it can produce executables for darwin arm64, AKA "M1" Macs. Because Go can't yet build universal binaries alone, and the Apple supplied tool to build universal binaries is unavailable on non-Darwin platforms, we simply build and distribute versions of the executable for both architectures, and select the appropriate one at runtime in Javascript. For backwards compatibility, an `app-builder` symlink to the amd64 executable is maintained.
…facts as one part
…conflicts in a different manner (#116)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
to resolve appimage issues in electron builder, and since we can't update electron-builder-binaries repo, we should just downgrade to the last working version of appimage (#126)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix: find the real parent node module --------- Co-authored-by: payne.fu <payne.fu@ringcentral.com> Co-authored-by: beyondkmp <beyondkmkp@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#139) * Conditionally adds `-snld` flag when detecting not `7za` binary to allow extracting relative links outside of host dir (to maintain backward compatibility with legacy 7za versus newer 7zz/7zzs/7zr.exe)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
All ICNS resource type entries are made of a type and a length. The resource type is always a 4 byte string - if it's shorter than 4 bytes, it is filled with space (0x20) characters. This is also the case for the 'TOC ' resource type, so add the missing space character. Modern ICNS tools often add a TOC\0x20 entry in the resource list, and that may not have been the case before. Add this to the fact that most linux-based builds are not based upon ICNS files and that should explain why this issue may not have been detected for 7 years (the fixed line was last changed in 2018).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.