Skip to content

fix(lint): resolve all 29 errcheck violations#27

Merged
shantoislamdev merged 1 commit into
mainfrom
fix-errcheck-violations
May 27, 2026
Merged

fix(lint): resolve all 29 errcheck violations#27
shantoislamdev merged 1 commit into
mainfrom
fix-errcheck-violations

Conversation

@shantoislamdev

Copy link
Copy Markdown
Owner

Fix

Resolves all 29 errcheck violations flagged by golangci-lint:

  • defer Close(): Replaced bare defer file.Close() with defer func() { _ = file.Close() }() across commands.go, init.go, generator.go, sampler.go, jsonl_test.go
  • fmt.Fprintln/Fprintf/w.Flush: Added explicit _ = for tabwriter output in commands.go (schema list, schema show, provider list)
  • provider.CloseAll/bar.Finish: Wrapped in _ = or deferred closure
  • os.Setenv/Unsetenv in tests: Replaced with .Setenv() (auto-cleanup, Go 1.17+) in secrets_test.go
  • test helpers: Added _ = to gen.Run, r.Register, os.Chmod, w.Close in test files
  • unsafe type assertion: Added comma-ok form in chat_test.go
  • tmpFile.Close on error paths: Added _ = for discarded close calls in generator.go

- Replace bare defer Close() with explicit _ = wrappers
- Add _ = to fmt.Fprintln/Fprintf/w.Flush calls writing to tabwriter
- Use t.Setenv() instead of os.Setenv/Unsetenv in tests
- Add _ = to provider.CloseAll, bar.Finish, gen.Run, r.Register
- Add comma-ok form to unsafe type assertion in chat_test.go
- Add _ = to tmpFile.Close on error paths
@shantoislamdev shantoislamdev merged commit dc5073a into main May 27, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant