fix(lint): enforce gofmt via fmt --diff CI step#26
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 644317e6b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
In golangci-lint v2, gofmt is classified as a formatter and cannot be placed in linters.enable (config load fails). Keep gofmt in formatters.enable and add a dedicated 'golangci-lint fmt --diff' CI step to enforce formatting on every PR.
shantoislamdev
force-pushed
the
fix-gofmt-linter-enforcement
branch
from
644317e to
5967964
Compare
Deploying kothaset with
|
| Latest commit: |
5967964
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://968b614f.kothaset.pages.dev |
| Branch Preview URL: | https://fix-gofmt-linter-enforcement.kothaset.pages.dev |
shantoislamdev
changed the title
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (from code review on #20)
In golangci-lint v2, gofmt is classified as a formatter — it cannot be placed in linters.enable (config load fails with gofmt is a formatter). Moving it to ormatters.enable alone means golangci-lint run no longer checks formatting, and unformatted Go files pass CI.
Fix