support socks proxy without password#1046
Conversation
- sourceforge: https://sourceforge.net/projects/iprelay/ - ip-relay: udp and tcp relay
|
I feel like @madeye is never going to approve this PR so I'm going to save my change requests for later. Thanks anyway. |
- modified ip-relay - socks proxy when no password - connect to socks proxy including ss-local - test on Huawei Honor 5A / Android 6.0
|
thx and just find a typo... would like to recreate one ... i will point out the typo in the commit |
|
You can push more commits without creating a new PR as long as you push it to the same branch. |
- add send_traffic_stat to ip-relay - correct traffic monitor - test on Huawei Honor 5A + Hnor Tablet 2 / Android 6.0
|
HI @dna2github, I think your changes are very useful: without password, shadowsocks-android will fall back to a simple socks5 proxy. This is really a clever approach. But as you know, this project is designed for shadowsocks protocol. So, it's almost impossible for me to merge this change, as socks proxy is not encrypted and this approach would cause very serious security problem in some scenarios, e.g. a honeypot with unencrypted socks5 proxy claims it a shadowsocks service. So, my suggestion is to keep your change as a fork. I'll keep this pull request open in case it's useful to someone. BTW, I found you're quite familiar with our project and able to write both C and Scala (Awesome!). If possible, please keep sending us pull requests. There will be many changes for shadowsocks-android in the next year. I hope you can join us to improve the project. Thanks, |
madeye
left a comment
madeye
left a comment
There was a problem hiding this comment.
The patch looks good. No comments from my side.
Mygod
left a comment
Mygod
left a comment
There was a problem hiding this comment.
You said you made changes to iprelay but you put everything in a single commit. Please create a separate repo, put original code as the first commit, your modified code as second commit, and use it as a submodule, just like our other native C libraries, so that other people can see what you did to iprelay without having to fire up a terminal and do a diff themselves.
|
@madeye Yes that's exactly what I thought. |
|
thx all for your comments. currently I have 3 commits and the first commit has the original ip-relay source code and modified ip-relay in the following commits. will create submodule for ip-relay when i have time. Happy to join you folks :) I have an idea to enhance ss-local. |
|
Really nice approach! This will also enable the possibility to use existing shadowsock client on other machines in LAN or use other proxy tools that provide SOCKS5 protocol. Even it won't be approved I'm gonna merge and compile it for my self 😀 |
|
Locked as off-topic. |
|
@madeye How about removing spam and unlock? |
|
Unlocked after removing SPAMs. |
|
This is exactly what I am trying to do! Unfortunately the build failed: |
madeye
force-pushed
the
master
branch
2 times, most recently
from
9bf3bf4 to
dbb02a8
Compare
Mygod
force-pushed
the
master
branch
6 times, most recently
from
ae23132 to
fa96067
Compare
|
this is one of the worst pull request i have seen for ss, it literally defeats the reason for creating ss in the first place why not just download any proxy application and work off that. |
|
#2454 added support for |
6 participants
Type of changes
Put an
xinside the [ ] that applies.Details