Skip to content

Conversation

@alejandro-colomar
Copy link
Collaborator

@alejandro-colomar alejandro-colomar commented Dec 31, 2025

Suggested-by: @Karlson2k


Hopefully, this smaller PR will pass the test suite.


Revisions:

v2
  • Use $bindir instead of $sbindir for passwd(1).
$ git rd 
1:  a884b9bd5 ! 1:  800be64d6 configure.ac, lib/Makefile.am: Respect $(sbindir) in PASSWD_PROGRAM
    @@ Metadata
     Author: Alejandro Colomar <alx@kernel.org>
     
      ## Commit message ##
    -    configure.ac, lib/Makefile.am: Respect $(sbindir) in PASSWD_PROGRAM
    +    configure.ac, lib/Makefile.am: Respect $(bindir) in PASSWD_PROGRAM
     
         Suggested-by: Evgeny Grin (Karlson2k) <k2k@drgrin.dev>
         Signed-off-by: Alejandro Colomar <alx@kernel.org>
    @@ lib/Makefile.am
      
     -DEFS =
     +DEFS = \
    -+  -DPASSWD_PROGRAM='"$(sbindir)/passwd"'
    ++  -DPASSWD_PROGRAM='"$(bindir)/passwd"'
      
      noinst_LTLIBRARIES = libshadow.la
      
v3
  • Rename PASSWD_PROGRAM => PATH_PASSWD, for consistency with <paths.h>.
$ git rd 
1:  800be64d6 = 1:  800be64d6 configure.ac, lib/Makefile.am: Respect $(bindir) in PASSWD_PROGRAM
-:  --------- > 2:  90e6a4840 lib/: Rename PASSWD_PROGRAM => PATH_PASSWD

@alejandro-colomar alejandro-colomar self-assigned this Dec 31, 2025
Suggested-by: Evgeny Grin (Karlson2k) <k2k@drgrin.dev>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
For consistency with <paths.h> definitions.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
@alejandro-colomar alejandro-colomar changed the title configure.ac, lib/Makefile.am: Respect $(sbindir) in PASSWD_PROGRAM configure.ac, lib/Makefile.am: Respect $(bindir) in PASSWD_PROGRAM Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants