add gdn custom conv1d#555
Conversation
Signed-off-by: zhaozx-cn <zhaozx2116@163.com>
Signed-off-by: zhaozx-cn <zhaozx2116@163.com>
There was a problem hiding this comment.
Code Review
This pull request refactors the causal_conv1d operator to support CANN graph mode, template kernels, and speculative decoding, introducing extensive host-side tiling, validation, and kernel dispatching logic. Feedback on the changes highlights several critical issues: a data type mismatch for num_accepted_tokens between the host-side implementation and the CANN/tiling validation code, thread-safety concerns regarding unprotected global static variables, potential race conditions and cross-device compatibility errors from using static global tensors (globalNumAcceptBuffer and globalTilingBuffer), and the omission of device compatibility checks for input tensors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Signed-off-by: zhaozx-cn <zhaozx2116@163.com>
Signed-off-by: zhaozx-cn <zhaozx2116@163.com>
Description
This PR adds GDN (Grouped Deformable Normalization) custom conv1d op, which could be used in:
Accuracy Test
Performance Test
Model:
Qwen/Qwen3.5-35B-A3BModel:
Qwen/Qwen3.5-397B-A17B