[WIP] Feature/add spectravista: reading spectral data from SVC *.sig#25
Open
georgejr45 wants to merge 3 commits into
Open
[WIP] Feature/add spectravista: reading spectral data from SVC *.sig#25georgejr45 wants to merge 3 commits into
georgejr45 wants to merge 3 commits into
Conversation
Owner
|
I will take a look as soon as possible. |
Owner
|
I am really sorry for the limited interactions - is this something ready to merge? I dont recall what the status is for this new feature. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
R-Fieldspectra can already read metadata from *.sig files. In #14 the SVC reading was already mentioned.
We have added read.sig() to also read the spectral data. A unit test and manage are created.
This is still a work in progress, we'll be using our own function in the near future, so we might do fixes if required.
Yours, Methun and Steffen