fix(cli): Suppress update banner after running update command#142
Merged
Conversation
PersistentPreRunE always spawned an async check that read the running binary's version. During `opentaint update`, that version is still the OLD one, so the check queued an "update available" hint for the very version being installed; PersistentPostRun then printed the banner after the successful update, telling the user to run the command they just ran. Skip the async check entirely when the subcommand is `update`, so no hint is ever queued for this command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PersistentPreRunE always spawned an async check that read the running binary's version. During
opentaint update, that version is still the OLD one, so the check queued an "update available" hint for the very version being installed; PersistentPostRun then printed the banner after the successful update, telling the user to run the command they just ran.Skip the async check entirely when the subcommand is
update, so no hint is ever queued for this command.