ci: add nightly multi-validator testnet convergence smoke (non-blocking)#828
Conversation
Scheduled + manual-dispatch workflow that boots a fresh 3-validator testnet from genesis, produces blocks, and asserts the validators converge on the same block hash — covering real BFT + libp2p + block production, which the in-process cargo tests can't. Not a PR gate (schedule/dispatch only), so a flaky network run never blocks a merge. scripts/ci-testnet-convergence.sh is self-contained (generates keystores + genesis, inits + starts N nodes on isolated loopback ports, polls for liveness, then checks block-hash agreement). Depends on #827 to bootstrap DPoS from genesis — merge that first.
|
Warning Review limit reached
More reviews will be available in 58 minutes and 28 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1 participant
What
A nightly (scheduled + manual-dispatch) workflow that boots a fresh 3-validator testnet from genesis on loopback, lets it produce blocks, and asserts every validator converges on the same block hash.
This exercises the layer the in-process tests in
cargo testcan't reach: real boot, BFT propose→prevote→precommit→finalize, libp2p peering, and block production. The deterministic state_root / apply-determinism invariants stay guarded by the in-process trie + 4-validator tests.Not a merge gate
Runs on
schedule(03:00 UTC) +workflow_dispatchonly — never onpull_request— so a flaky network run cannot block a merge. It is intentionally NOT in branch-protection required checks. (Matches how reth/lighthouse keep heavy network/integration suites off the per-PR path.)How
scripts/ci-testnet-convergence.shis self-contained: it generates N validator keystores + a genesis with them, inits + starts each node on isolated loopback ports with the testnet fork schedule, polls until all reach a target height (liveness), then checks block-hash agreement at a common height (convergence). Verified locally: 3 validators boot from genesis, advance 0 → 26, and converge on an identical block hash.Depends on #827
The script only passes once the binary can bootstrap a fresh DPoS testnet from genesis, which #827 (
fix(consensus): seat genesis validators in AuthorityManager) provides. Merge #827 first, otherwise the nightly will fail with "BFT activation blocked: active_set is empty".