Open
Conversation
added 2 commits
November 5, 2024 10:23
Since only a few history entries are kept, the history size doesn't grow much. On the positive side, this can be used for the checks to give more information downstream, about their work. Alternatively we could consider a more complex change adding a boolean option to CheckConfig/Check, and storing the output only if that is set. Protocol buffer compilation result is added as a followup commit. Signed-off-by: Guido Trotter <guido@hudson-trading.com>
Signed-off-by: Guido Trotter <guido@hudson-trading.com>
Author
|
Hi! Is there any chance we can discuss this simple one-liner fix? It's really just one field, plus the recompiling of the protocol buffer... Thanks a lot!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output field can be used for debugging, or to share extra information between the check and downstream from sensu.