-
Notifications
You must be signed in to change notification settings - Fork 2
refactor: use camino's UTF-8 paths everywhere #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3fa3c51 to
5a86298
Compare
victor-linroth-sensmetry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Should wrapfs also be converted to camino paths/pathbufs? If there is nothing hindering us from doing this it seems like it could make things a bit more concise and uniform.
I left some of them using std |
Long term I'm considering removing the dirs dependency anyway, since we probably want more fine grained control over where to load config files, but there's no urgency at the moment. |
19660f3 to
e05c8bb
Compare
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
dd1cceb to
0e65a85
Compare
Also use
camino-tempfileinstead oftempfileto get UTF-8 paths for tempfiles.Closes #136.