Skip to content

[UIK-3807][inline-input] removed some non-working properties#2757

Open
ilyabrower wants to merge 5 commits intorelease/v17from
UIK-3807/remove-deprecated-inline-input-props
Open

[UIK-3807][inline-input] removed some non-working properties#2757
ilyabrower wants to merge 5 commits intorelease/v17from
UIK-3807/remove-deprecated-inline-input-props

Conversation

@ilyabrower
Copy link
Contributor

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

@@ -38,19 +38,6 @@ export type InlineInputProps = BoxProps & {
* Text value of input. Should be used with `onChange` property together
*/
value?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilyabrower wouldn't it be logical to remove value from here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you're righte

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants