Open
Conversation
radwo
reviewed
Jan 7, 2020
Member
radwo
left a comment
radwo
left a comment
There was a problem hiding this comment.
We will use this API for a job page?
| // ## The PLAIN_TEXT format | ||
| // | ||
| // When the PLAIN_TEXT format is requested, the GetLogsResponse.content contains | ||
| // the output of the job after all all the unix escape characters have been |
| // processed PLAIN_TEXT format. | ||
| // | ||
| // The Log API is resticting the payload length size to 10000 log events and | ||
| // the total response size 64 megabytes. The response contains infomrmation |
| // The logs can be fetched in two formats. The raw JSON_LINES format, or the | ||
| // processed PLAIN_TEXT format. | ||
| // | ||
| // The Log API is resticting the payload length size to 10000 log events and |
Member
There was a problem hiding this comment.
this 10k events is our hard limit? This job has 17_769 events and "only" 4,2 MB.
| // To fetch the full logs, you need to iterate till the end. Example for a log | ||
| // that has 1040 log lines: | ||
| // | ||
| // GetLogs(start_from: 0) # => Response { length: 1000, end_reached: false } |
Member
There was a problem hiding this comment.
1k is page size? currently we are fetching 10k events at once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.